Use configured browser locales for date formatting
What does this MR do?
This allows us to decide a little better what a user wants as a locale
for using with the Intl browser APIs. If they have set their GitLab to
a language, it will check whether navigator.languages
contains
matching ones. This function always adds en
as a fallback in order to
have date renders if all fails before it.
- Example one: GitLab language is
en
and browser languages are:['en-GB', 'en-US']
. We would choose['en-GB', 'en-US', 'en']
as the preferred locales, the Intl APIs would try to format first as British English, if that isn't available US or any English. - Example two: GitLab language is
en
and browser languages are:['de-DE', 'de']
. We would choose['en']
, so the Intl APIs would prefer English formatting in order to not have German dates mixed with English GitLab UI texts. If the user wants for example British English formatting (24h, etc), they could set their browser languages to['de-DE', 'de', 'en-GB']
. - Example three: GitLab language is
de
and browser languages are
['en-US', 'en']
. We would choose['de', 'en']
, aligning German dates with the chosen translation of GitLab.
This function is currently only used for absolute dates:
Changelog: changed
Screenshots or Screencasts (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Lukas Eipert