Skip to content

DB testing: Refactor to have stateful observers per migration

What does this MR do?

Related to gitlab-org/database-team/gitlab-com-database-testing#24 (closed)

Refactor lib/gitlab/database/migrations/instrumentation.rb so that it creates an observer per migration, passing in the details of the migration being observed.

Test comment: !60842 (comment 624370478)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Alishan Ladhani

Merge request reports

Loading