Skip to content

Renders placeholder notes markdown as rendered HTML

Phil Hughes requested to merge ph/placeholderNoteRendering into master

What does this MR do?

Previously we would render the placeholder notes raw markdown instead of rendered HTML. This could cause a jarring effect when the new note comes in with the correct rendered markdown.

This changes that by using the marked library we have on the frontend to render the markdowns raw data as rendered HTML.

Screenshots or Screencasts (strongly suggested)

Screen_Recording_2021-07-09_at_14.00.25

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading