Skip to content

Fixes expansion bug with diffs virtual scroller

Phil Hughes requested to merge ph/collapsedFileVirtualScrollerBug into master

What does this MR do?

Fixes a bug where sometimes collapsed diff files would not actually be collapsed inside of the virtual scroller. This gets caused by watchers getting fired incorrectly and the state being updated incorrectly.

This removes the local state and makes the diff file object the single source of truth to whether a file is collapsed or not.

Screenshots or Screencasts (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading