Skip to content

Fix labelFilterParam value in issuable_list_root

What does this MR do?

When set as null, the labelFilterParam passed from issuable_list_root.vue to issuable_item.vue does not fallback to the default value of label_name. Instead, we should use undefined so the prop falls back properly.

This bug affects:

  • test_case_list_root.vue used in Test cases list.
  • epics_list_root.vue used in Epics list (behind a feature flag vue_epics_list).

Screenshots or Screencasts (strongly suggested)

Page Before After
Epics list /groups/gitlab-org/-/epics?null[]=Gencell /groups/gitlab-org/-/epics?label_name[]=Gencell
Test cases list /gitlab-org/gitlab-shell/-/quality/test_cases?null[]=Reufunc /gitlab-org/gitlab-shell/-/quality/test_cases?label_name[]=Reufunc

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Justin Ho Tuan Duong

Merge request reports

Loading