Update policy for granting `build_read_container_image` to users
What does this MR do?
We are in the process of migrating code to use ProjectFeature#container_registry_access_level instead of Project#container_registry_enabled.
With projects.container_registry_enabled, the container registry had the same visibility as the project. So if the project is public, the container registry is public. Now, with projects.container_registry_access_level, if container_registry_access_level is set to PRIVATE, the container registry should be private even if the project is public.
project_features.container_registry_access_level can currently contain the following values, ENABLED and DISABLED. This mimics the behavior of projects.container_registry_enabled. Before we start allowing the 3rd possible value (PRIVATE), we need to ensure that all locations where we check if the container registry is enabled should be changed to check if the container registry is enabled for the current user/actor.
This MR updates project_policy.rb to grant build_read_container_image permission to all signed in users (for public or internal projects) only if container registry is ENABLED.
Screenshots or Screencasts (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) - I have tested this MR in all supported browsers, or it's not needed.
- I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- Label as security and @ mention
@gitlab-com/gl-security/appsec - The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- Security reports checked/validated by a reviewer from the AppSec team
Related to #18792 (closed)