Skip to content

Support blank string for RAILS_RELATIVE_URL_ROOT

Heinrich Lee Yu requested to merge puma-support-blank-relative-url-root into master

What does this MR do?

Changes our Rackup file to also handle an empty RAILS_RELATIVE_URL_ROOT value.

We want to change the GDK default from / to an empty string because / is an invalid relative url root and causes problems with gems like premailer-rails. See #195514 (closed) details.

We can also change GDK to not set the ENV var at all but it complicates the changes and I think it's still better that we also support an empty string here.

Screenshots or Screencasts (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu

Merge request reports

Loading