Not removing group in after bloock
What does this MR do?
I'm removing the group remove logic in after block here. We already have cleanup logic to take care of this so if race condition happens we run into this error
QA::Resource::ApiFabricator::ResourceNotDeletedError:
Resource at http://gitlab-ee-c09e9a31.test/api/v4/groups/7?private_token=[****] could not be deleted (400): `{"message":"Group has been already marked for deletion"}`.
Example job: https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/jobs/1424266172, also have been reported a few times here #330823 (closed)
I think removing the projects instead is sufficient.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Related to #330823 (closed)
Edited by Tiffany Rea