Fix background color of markdown code in dark mode
What does this MR do?
When using dark mode, the code
highlight in markdown text (in comments) is not very visible as it is using the same background color as the light mode.
This MR sets a new background-color
in app/assets/stylesheets/application_dark.scss
that makes the highlight more visible for dark mode but remains unchanged for light mode.
Given that the description has a darker background color, the code highlight is already visible there but with this change it would be shown a little lighter.
Screenshots or Screencasts (strongly suggested)
Comments before | Comments after |
---|---|
Light mode value before | Light mode value after |
Description before | Description after |
---|---|
l |
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Eugenia Grieff