Skip to content

New cop to enforce using new GraphQL types

Brett Walker requested to merge bw-rubocop-graphql-types into master

What does this MR do?

Cop that enforce the use of the new GraphQL Types, based on https://docs.gitlab.com/ee/development/contributing/style_guides.html#creating-new-rubocop-cops

  • GraphQL::ID_TYPE to GraphQL::Types::ID
  • GraphQL::INT_TYPE to GraphQL::Types::Int
  • GraphQL::STRING_TYPE to GraphQL::Types::String
  • GraphQL::BOOLEAN_TYPE to GraphQL::Types::Boolean

Related to #210556 (closed) and !66113 (closed) and #336292 (closed)

Screenshots or Screencasts (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Brett Walker

Merge request reports

Loading