Skip to content

Gracefully exit from escalation workers on failure

Sarah Yasonik requested to merge sy-dont-raise-from-escalation-workers into master

What does this MR do?

Related issue: #337259 (closed)

IncidentManagement::PendingEscalations::AlertCheckWorker and IncidentManagement::PendingEscalations::AlertCreateWorker both raise errors when the input object ids don't correspond an existing record. In that scenario, we wouldn't expect those records to ever exist, so we should just return from the worker silently. Otherwise, the job will be continually retried, even though we never expect it to be successful.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Sarah Yasonik

Merge request reports

Loading