Skip to content

ci: Tag QA image with the commit SHA instead of branch name

Rémy Coutable requested to merge 336409-consider-tagging-qa-image-with-the-commit-sha-instead-of-the-branch-name into master

What does this MR do?

This changes the tag we use for the QA image from branch name to commit SHA for which the image is actually built for.

Now that Cleanup policies are available, we shouldn't bother limiting the number of images we create, and favor stability/idempotency instead:

Background

A race condition was discovered in #335717 (comment 630112309), where a master QA image could be more recent that the GitLab image against which it is run.

This is because we currently tag QA images with the branch name, so it's possible that a master QA image is updated before end-to-end tests are run against a given GitLab image.

Related to #336409 (closed).

Edited by Rémy Coutable

Merge request reports