Skip to content

Move placement of "Compliance Framework" setting to Settings->General after Badges

What does this MR do?

This MR moves the compliance framework selector from the top of the general settings to a new Compliance framework section just after badges.

The underlying framework selection code hasn't changed, it is just being wrapped in an expandable section and the rspec tests have been updated.

Screenshots or Screencasts (strongly suggested)

Screencast

Screen_Recording_2021-07-20_at_09.48.42

Previous section

Before After
image image

New section

No frameworks with no permission to edit No permission to edit No frameworks with permission to edit Editable
image image image image

Does this MR meet the acceptance criteria?

Setup & testing

Note: This feature requires at least GitLab Premium

  1. Go to [HOST]/[GROUP]/[PROJECT]/edit and check the compliance framework is not in the top section but a new expandable one
  2. As a group owner
    1. With no compliance frameworks, check the create text with link is shown
    2. With compliance frameworks, check that you can set a framework using the dropdown
  3. As a maintainer
    1. With no compliance frameworks, check the no frameworks text is shown
    2. With compliance frameworks, check that the disabled input is shown with the defined framework value

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #324085 (closed)

Edited by Robert Hunt

Merge request reports

Loading