Draft: Remove authenticate_non_public: true in debian package endpoints
What does this MR do?
Show that #300917 (comment 629915606) is not fixable by removing authenticate_non_public: true
.
The following tests fail with expected the response to have status code :unauthorized but it was 404. The response was: {"message":"404 Group Not Found"}
:
rspec ./spec/requests/api/debian_group_packages_spec.rb[1:1:1:1:18:1:1] # API::DebianGroupPackages GET groups/:id/-/packages/debian/dists/*distribution/Release.gpg behaves like Debian repository read endpoint with valid container visibility_level: :private, user_role: :anonymous, member: false, user_token: true, expected_status: :unauthorized, expected_body: nil behaves like Debian repository GET request returns unauthorized
rspec ./spec/requests/api/debian_group_packages_spec.rb[1:1:1:2:1:1:1:1] # API::DebianGroupPackages GET groups/:id/-/packages/debian/dists/*distribution/Release.gpg behaves like Debian repository read endpoint behaves like rejects Debian access with unknown container id with an unknown container as anonymous behaves like Debian repository GET request returns unauthorized
rspec ./spec/requests/api/debian_group_packages_spec.rb[1:2:1:1:18:1:1] # API::DebianGroupPackages GET groups/:id/-/packages/debian/dists/*distribution/Release behaves like Debian repository read endpoint with valid container visibility_level: :private, user_role: :anonymous, member: false, user_token: true, expected_status: :unauthorized, expected_body: nil behaves like Debian repository GET request returns unauthorized
rspec ./spec/requests/api/debian_group_packages_spec.rb[1:2:1:2:1:1:1:1] # API::DebianGroupPackages GET groups/:id/-/packages/debian/dists/*distribution/Release behaves like Debian repository read endpoint behaves like rejects Debian access with unknown container id with an unknown container as anonymous behaves like Debian repository GET request returns unauthorized
rspec ./spec/requests/api/debian_group_packages_spec.rb[1:3:1:1:18:1:1] # API::DebianGroupPackages GET groups/:id/-/packages/debian/dists/*distribution/InRelease behaves like Debian repository read endpoint with valid container visibility_level: :private, user_role: :anonymous, member: false, user_token: true, expected_status: :unauthorized, expected_body: nil behaves like Debian repository GET request returns unauthorized
rspec ./spec/requests/api/debian_group_packages_spec.rb[1:3:1:2:1:1:1:1] # API::DebianGroupPackages GET groups/:id/-/packages/debian/dists/*distribution/InRelease behaves like Debian repository read endpoint behaves like rejects Debian access with unknown container id with an unknown container as anonymous behaves like Debian repository GET request returns unauthorized
rspec ./spec/requests/api/debian_group_packages_spec.rb[1:4:1:1:18:1:1] # API::DebianGroupPackages GET groups/:id/-/packages/debian/dists/*distribution/:component/binary-:architecture/Packages behaves like Debian repository read endpoint with valid container visibility_level: :private, user_role: :anonymous, member: false, user_token: true, expected_status: :unauthorized, expected_body: nil behaves like Debian repository GET request returns unauthorized
rspec ./spec/requests/api/debian_group_packages_spec.rb[1:4:1:2:1:1:1:1] # API::DebianGroupPackages GET groups/:id/-/packages/debian/dists/*distribution/:component/binary-:architecture/Packages behaves like Debian repository read endpoint behaves like rejects Debian access with unknown container id with an unknown container as anonymous behaves like Debian repository GET request returns unauthorized
rspec ./spec/requests/api/debian_group_packages_spec.rb[1:5:1:1:18:1:1] # API::DebianGroupPackages GET groups/:id/-/packages/debian/pool/:component/:letter/:source_package/:file_name behaves like Debian repository read endpoint with valid container visibility_level: :private, user_role: :anonymous, member: false, user_token: true, expected_status: :unauthorized, expected_body: nil behaves like Debian repository GET request returns unauthorized
rspec ./spec/requests/api/debian_group_packages_spec.rb[1:5:1:2:1:1:1:1] # API::DebianGroupPackages GET groups/:id/-/packages/debian/pool/:component/:letter/:source_package/:file_name behaves like Debian repository read endpoint behaves like rejects Debian access with unknown container id with an unknown container as anonymous behaves like Debian repository GET request returns unauthorized
Screenshots or Screencasts (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team