Refactor admin applications to use doorkeeper HAML partials
requested to merge 332844-create-a-download-for-the-secret-when-creating-an-application-in-admin-applications into master
📖 What does this MR do?
Preparation for #332844 (closed)
Refactors Admin area -> Applications -> View an application to use the shared shared/doorkeeper/applications/show
HAML partial. This will prepare us for #332844 (closed) so we can make the same change to Admin area applications, Group applications, and User applications in one shared HAML partial.
💻 Local testing
- Navigate to Menu -> Admin -> Applications
- Click New application and complete the form
- Screen should be unchanged as this is just a refactor
📷 Screenshots
Before and After expected to be the same
View | Before | After |
---|---|---|
Admin applications | ||
Group applications | ||
User applications |
🚦 Does this MR meet the acceptance criteria?
Conformity
- [-] I have included changelog trailers, or none are needed. (Does this MR need a changelog?)
- Not needed, developer facing change
- [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
-
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) - [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
- [-] I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.)
- [-] I have tested this MR in all supported browsers, or it's not needed.
- [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Edited by Peter Hegman