Skip to content

Fix "Remove" button in Slack app integration

What does this MR do?

The data-method attribute was removed by our config of DOMpurify since we are using v-safe-html. Since this is trusted input (comes from our own code), we should allow these attributes for Rails remote link functionality.

Screenshots or Screencasts (strongly suggested)

NA

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #335877 (closed)

Edited by Justin Ho Tuan Duong

Merge request reports

Loading