Skip to content

Flag ActiveSupport::JSON in Gitlab::Json Cop

Matthias Käppler requested to merge mk-json-cop-activesupport into master

What does this MR do?

We have a Cop in place, Cop::Gitlab::Json, which makes sure we prefer our own Gitlab::Json wrapper over the json gem.

However, it did not include a check that tests for ActiveSupport::JSON, which we should also avoid for the same reasons.

This change makes sure the cop catches calls to ActiveSupport::JSON as well and fixes existing cases.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Matthias Käppler

Merge request reports

Loading