Skip to content

Add validation to delete blob modal

Samantha Ming requested to merge 335743-delete-blob-validation into master
MR Changes
👉 This MR Add validation
tbd Add Hint

What does this MR do?

This MR adds validation to the delete blob modal using our validation directive.

Validation Validation
image

Testing Case

This feature is behind a feature flag, to turn on:

rails c

Feature.enable(:refactor_blob_viewer)
  1. Navigate to Repository > Files
  2. Click on a file to get to the Blob page
  3. Click on the "Delete" button

There is validation:

  • Commit message can not be empty
  • Target branch can not be empty
  • Delete file button is disabled when there is validation error(s)

image

Screenshots or Screencasts (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #335743 (closed)

Edited by Samantha Ming

Merge request reports

Loading