Skip to content

Add import members from project modal [RUN ALL RSPEC]

What does this MR do?

Replaces the /-/project_members/import page, and the target of the "Import a project" button, with a modal.

Does not include a changelog as the "Import a project" button is still behind the :invite_members_group_modal feature flag

Resolves https://gitlab.com/gitlab-org/gitlab/-/issues/295200

Related to feature flag rollout issue: https://gitlab.com/gitlab-org/gitlab/-/issues/247208

Screenshots or Screencasts (strongly suggested)

before after
import-page import-1
Screen_Shot_2021-07-22_at_8.12.01_AM Screen_Shot_2021-07-22_at_8.13.04_AM
Screen_Shot_2021-07-22_at_8.25.30_AM import-3
Screen_Shot_2021-07-22_at_8.27.55_AM Screen_Shot_2021-07-22_at_12.45.49_AM

With error:

before after
Screen_Shot_2021-08-26_at_5.20.54_PM Screen_Shot_2021-08-26_at_5.23.59_PM

To test locally:

  1. enable the feature flag: Feature.enable(:invite_members_group_modal) in a rails console

  2. visit the Project Members page ( Project information -> Members )

  3. Select "Import from a project" button:

mobile large
Screen_Shot_2021-08-31_at_5.48.17_PM Screen_Shot_2021-08-31_at_5.49.37_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #295200

Edited by Jackie Fraser

Merge request reports

Loading