Skip to content

Display pending user count when modifying user cap

Vijay Hawoldar requested to merge vij-sm-pending-user-count-fe into master

What does this MR do?

This MR makes use of the pending user count added in !66619 (merged), to display the number of pending users that may be auto-approved if an instance admin modifies the signup user cap accordingly (increases or removes cap).

You may notice a slight deviation from the UX design has been made - the modal title has dropped the word all, as per Amanda's comment here: #331554[Frame_1.png]

This MR also adjusts the logic used to display the modal, to only display it if there are pending members that maybe auto-approved (also mentioned in the linked design issue above)

Refs #328237 (closed)

Screenshots or Screencasts (strongly suggested)

Design:

Frame_1

UX Issue

single pending user multiple pending users
Screenshot_2021-07-22_at_08.53.03 Screenshot_2021-07-22_at_08.53.58

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Vijay Hawoldar

Merge request reports

Loading