Skip to content

Fix whats new top positioning with system-header and performance-bar

What does this MR do?

Fix whats news top positioning with system-header and performance-bar:

  • add $system-header-height to margin-top of .whats-new-drawer when .with-system-header present in body to respect the additional hight of the system header
  • add $system-header-height and $performance-bar-height to margin-top of .whats-new-drawer when .with-system-header and .with-performance-bar present in body to respect the additional hight of the system header and performance bar

Screenshots or Screencasts (strongly suggested)

What's new broken with system header:

gitlab_whats-new_broken-system-header

What's new broken with system header and performance bar:

gitlab_whats-new_broken-system-header-and-performance-bar

What's new fixed:

gitlab_whats-new_fixed

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #336660 (closed)

Edited by Daniel Ziegenberg

Merge request reports

Loading