Update copy in account recovery settings global alert
requested to merge 297366-the-banner-prompting-users-to-check-their-account-recovery-settings-causes-confusion into master
📖 What does this MR do?
Related to #297366 (closed)
Updates the copy in the account recovery settings alert let the user know they should ensure their 2FA settings are up to date. Previously there was some confusion about what settings should be checked. This MR also takes the opportunity to refactor this alert to use the app/views/shared/_global_alert.html.haml HAML partial which helps improve consistency of global alerts.
💻 Local testing
- Download and apply this patch: test-alert.patch
git apply <path to patch>
- Delete the
UserCallout
record for this alertbin/rails console
UserCallout.where({ feature_name: 12 }).destroy_all
- Reload the page
📷 Screenshots
View | Before | After |
---|---|---|
Desktop | ||
Mobile |
🚦 Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) - [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
-
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) - [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. - [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Edited by Peter Hegman