Rescue stuck resource groups
What does this MR do?
As we discovered in the bug ticket, resource group can be stuck when a build is failed with data_integrity_failure
, which doesn't execute the Ci::Build
state machine hooks to release the resources in a regular operation.
This MR introduces the check mechanism to release stale builds in the sidekiq worker.
stuck resource groups on gitlab.com
There are 31 jobs currently struck in the gitlab.com:
[ gprd ] production> Ci::Resource.joins(:processable).where('ci_builds.status IN (?)', Ci::HasStatus::COM
PLETED_STATUSES).where('ci_builds.updated_at < ?', 1.day.ago).count
=> 31
All jobs are failed by the data_integrity_failure
.
[ gprd ] production> Ci::Resource.joins(:processable).where('ci_builds.status IN (?)', Ci::HasStatus::COM
PLETED_STATUSES).where('ci_builds.updated_at < ?', 1.day.ago).distinct.pluck('ci_builds.failure_reason')
=> ["data_integrity_failure"]
Related #335537 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Shinya Maeda