Replace Dependency List custom sorting with GlSorting component
What does this MR do?
Replace custom sorting with GlSorting component
A snapshot test was removed, since it provided almost no value.
Using GlSorting
has changed the styling slightly, although not in
a harmful way: the width of the dropdown is fixed, instead of scaling
with the amount of text in the selected item.
The GlSorting
component may not be fully Pajamas-compliant, and fixing
that may bring this UI back to nearly how it looked previously. This is being addressed in gitlab-ui!2316 (merged).
Addresses part of #335066 (closed).
Draft status
Depends on !66672 (merged).
Screenshots or Screencasts (strongly suggested)
Before | After | |
---|---|---|
Medium+ device | ||
Small device |
Does this MR meet the acceptance criteria?
Conformity
- [-] I have included changelog trailers, or none are needed. (Does this MR need a changelog?)
- [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
-
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) - [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) - [-] I have tested this MR in all supported browsers, or it's not needed.
- [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Edited by Mark Florian