Finalize converting geo_job_artifact_deleted_events
What does this MR do?
This MR finalizes the conversion to bigint for the geo_job_artifact_deleted_events
table, following the pattern in !64779 (merged)
Timings
create index concurrently index_geo_job_artifact_deleted_events_on_job_artifact_id_bigint ON geo_job_artifact_deleted_events(job_artifact_id);
- 17ms. (database lab) This table is empty on database lab. I believe entries are removed from it as they are processed, so this makes sense.
Migration Output
Up
== 20210722155635 FinalizeConvertGeoJobArtifactDeletedEventsBigint: migrating = -- transaction_open?() -> 0.0000s -- index_exists?("geo_job_artifact_deleted_events", "job_artifact_id_convert_to_bigint", {:name=>"index_geo_job_artifact_deleted_events_on_job_artifact_id_bigint", :algorithm=>:concurrently}) -> 0.0019s -- execute("SET statement_timeout TO 0") -> 0.0005s -- add_index("geo_job_artifact_deleted_events", "job_artifact_id_convert_to_bigint", {:name=>"index_geo_job_artifact_deleted_events_on_job_artifact_id_bigint", :algorithm=>:concurrently}) -> 0.0066s -- execute("RESET ALL") -> 0.0006s -- execute("LOCK TABLE geo_job_artifact_deleted_events IN ACCESS EXCLUSIVE MODE") -> 0.0005s -- quote_column_name("job_artifact_id_tmp") -> 0.0000s -- quote_column_name("job_artifact_id") -> 0.0000s -- quote_column_name("job_artifact_id_convert_to_bigint") -> 0.0000s -- execute("ALTER TABLE geo_job_artifact_deleted_events RENAME COLUMN \"job_artifact_id\" TO \"job_artifact_id_tmp\"") -> 0.0006s -- execute("ALTER TABLE geo_job_artifact_deleted_events RENAME COLUMN \"job_artifact_id_convert_to_bigint\" TO \"job_artifact_id\"") -> 0.0005s -- execute("ALTER TABLE geo_job_artifact_deleted_events RENAME COLUMN \"job_artifact_id_tmp\" TO \"job_artifact_id_convert_to_bigint\"") -> 0.0005s -- change_column_default("geo_job_artifact_deleted_events", "job_artifact_id", nil) -> 0.0018s -- change_column_default("geo_job_artifact_deleted_events", "job_artifact_id_convert_to_bigint", 0) -> 0.0016s -- quote_table_name("trigger_f1ca8ec18d78") -> 0.0000s -- execute("ALTER FUNCTION \"trigger_f1ca8ec18d78\" RESET ALL") -> 0.0006s -- execute("DROP INDEX index_geo_job_artifact_deleted_events_on_job_artifact_id") -> 0.0006s -- rename_index("geo_job_artifact_deleted_events", "index_geo_job_artifact_deleted_events_on_job_artifact_id_bigint", "index_geo_job_artifact_deleted_events_on_job_artifact_id") -> 0.0006s == 20210722155635 FinalizeConvertGeoJobArtifactDeletedEventsBigint: migrated (0.0396s)
Down
== 20210722155635 FinalizeConvertGeoJobArtifactDeletedEventsBigint: reverting = -- transaction_open?() -> 0.0000s -- index_exists?("geo_job_artifact_deleted_events", "job_artifact_id_convert_to_bigint", {:name=>"index_geo_job_artifact_deleted_events_on_job_artifact_id_bigint", :algorithm=>:concurrently}) -> 0.0028s -- execute("SET statement_timeout TO 0") -> 0.0005s -- add_index("geo_job_artifact_deleted_events", "job_artifact_id_convert_to_bigint", {:name=>"index_geo_job_artifact_deleted_events_on_job_artifact_id_bigint", :algorithm=>:concurrently}) -> 0.0046s -- execute("RESET ALL") -> 0.0005s -- execute("LOCK TABLE geo_job_artifact_deleted_events IN ACCESS EXCLUSIVE MODE") -> 0.0005s -- quote_column_name("job_artifact_id_tmp") -> 0.0000s -- quote_column_name("job_artifact_id") -> 0.0000s -- quote_column_name("job_artifact_id_convert_to_bigint") -> 0.0000s -- execute("ALTER TABLE geo_job_artifact_deleted_events RENAME COLUMN \"job_artifact_id\" TO \"job_artifact_id_tmp\"") -> 0.0005s -- execute("ALTER TABLE geo_job_artifact_deleted_events RENAME COLUMN \"job_artifact_id_convert_to_bigint\" TO \"job_artifact_id\"") -> 0.0005s -- execute("ALTER TABLE geo_job_artifact_deleted_events RENAME COLUMN \"job_artifact_id_tmp\" TO \"job_artifact_id_convert_to_bigint\"") -> 0.0005s -- change_column_default("geo_job_artifact_deleted_events", "job_artifact_id", nil) -> 0.0017s -- change_column_default("geo_job_artifact_deleted_events", "job_artifact_id_convert_to_bigint", 0) -> 0.0017s -- quote_table_name("trigger_f1ca8ec18d78") -> 0.0000s -- execute("ALTER FUNCTION \"trigger_f1ca8ec18d78\" RESET ALL") -> 0.0006s -- execute("DROP INDEX index_geo_job_artifact_deleted_events_on_job_artifact_id") -> 0.0006s -- rename_index("geo_job_artifact_deleted_events", "index_geo_job_artifact_deleted_events_on_job_artifact_id_bigint", "index_geo_job_artifact_deleted_events_on_job_artifact_id") -> 0.0006s == 20210722155635 FinalizeConvertGeoJobArtifactDeletedEventsBigint: reverted (0.0257s)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Edited by Michael Kozono