Skip to content

Draft: Don't publish an experiment to the database under some circumstances

What does this MR do?

We shouldn’t be publishing an experiment as an ExperimentSubject to our database under certain circumstances, such as when the experiment is disabled or when the current subject has been excluded from the experiment by the exclude! method.

The current behavior is unexpected and is causing me some grief with this MR as it is still creating ExperimentSubject records even when the current subject should be excluded (via the exclude! calls).

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Dallas Reedy

Merge request reports

Loading