Use non-predefined variables inside CI include blocks
What does this MR do?
- Adds the ability to use project, group and instance CI variables inside an
include
block in a.gitlab-ci.yml
file. - It should follow the same CI variable presidence as normal.
How to test
- Create two projects both with
.gitlab-ci.yml
files. - Add an
include:
block to one that includes the file in the other.- Define any of the
include
variables (file
,project
, orref
) as a variable at the project, group or instance level.
- Define any of the
- Assert that the CI pipeline includes as expected.
Example
include:
file: $FILENAME
project: $EXTERNAL_PROJECT_NAME
ref: $SOME_REF_VARIABLE
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #219065 (closed)
Edited by Max Woolf