Skip to content

Took the NotesApp out of the global scope

Denys Mishunov requested to merge 11918-notes-app into master

What does this MR do?

Instead of exposing the notes app (the discussions in Issues and Epics) instantly when the module is imported, we allow the modules, requiring the notes app decide on their own when to initialize the notes app.

This is the very first step in optimising the loading performance of the Knowldge_Design_Single route.

This MR allows making sure that the notes/comments do not get processed outside of initShowIssue() that is going to be explicitly controlled and called on the next step of performance optimization for the Single Design route (next MR).

Screenshots or Screencasts (strongly suggested)

No visual changes

How to setup and validate locally (strongly suggested)

  1. Visit any issue or epic with discussions
  2. Make sure the discussions still get loaded and rendered

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Related to gitlab-com/www-gitlab-com#11918 (closed)

Edited by Denys Mishunov

Merge request reports

Loading