Allow Limitable to use an override feature flag
What does this MR do?
This MR is a prerequisite to the [Feature flag] Rollout of ci_runner_limits (#329438). It expands the Limitable concern to allow it to cover the scenario described in "selectively disabling by actor". The Limitable functionality remains unchanged unless the developer sets the new limit_feature_flag_for_override class attribute. At that point, enabling the feature flag designated by limit_feature_flag_for_override will cause the limit to not apply. This allows for scenarios where you might want to gradually roll out a feature but be able to disable certain actors that are known to be problematic. A specific scenario where this will come handy is https://gitlab.com/gitlab-org/gitlab/-/issues/321368#note_637846069.
Screenshots or Screencasts (strongly suggested)
How to setup and validate locally (strongly suggested)
The new tests now cover both the new functionality (:limit_feature_flag_for_override) and functionality that wasn't previously being tested (:limit_feature_flag`).
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Part of #321368