Skip to content

Reduce Markdown cache updates during rolling deploy

Heinrich Lee Yu requested to merge 337291-prevent-markdown-cache-flipflop into master

What does this MR do?

Skips saving of Markdown cache if persisted data is newer than the current version.

This happens when some Markdown cache is generated on a newer node that has the cache version incremented during a rolling deploy or Canary deployment and then viewed again on an older node.

We do this so that we won't keep on updating the record back-and-forth when it is viewed on the different nodes with different Markdown cache version.

Related to #337291 (closed)

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Heinrich Lee Yu

Merge request reports

Loading