Skip to content

Remove dataBackground property from chart

Savas Vedova requested to merge svedova-remove-databackground-property into master

What does this MR do?

This commit removes the dataBackground property from the chart options so that it behaves similar to the other charts on GitLab.

Especially when gitlab-ui!2185 (merged) will be merged, the chart looks much different due to the breaking changes. In order to avoid that, I've created this MR beforehand.

Screenshots or Screencasts (strongly suggested)

Today With Echarts 5 After
image Screenshot_2021-07-30_at_16.42.24 Screenshot_2021-07-30_at_16.40.40

How to setup and validate locally (strongly suggested)

You'll need to have the Security Dashboard enabled to view this chart. This is an EE feature, so you'll also need a license. Here are the steps to produce vulnerabilities locally:

  1. Clone https://gitlab.com/gitlab-examples/security/security-reports/
  2. Run the pipeline by going into Your project > CI/CD > Pipelines
  3. Click on run pipeline for master branch

It should generate the list. You should have the runner installed in order to run this.

Then using the following command you can register the runner, it guides you pretty good:

$ gitlab-runner register

Once it's installed this is how I run the runner:

$ gitlab-runner --log-level debug run local-runner --config ~/.gitlab-runner/config.toml restart

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading