Skip to content

Change `db_role_for_connection` to support many load balancers

What does this MR do?

Based on: !67338 (merged).

This fixes db_role_for_connection by completely removing this from the context of LB, removing all tracking, and additional handling of mutexes.

We depend here on a properly named connection pools that are created, for which the role can be read from connection specification.

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Thong Kuah

Merge request reports

Loading