Add rules support for CI pipeline include
What does this MR do?
This MR adds the support of include:rules:if
.
- We don't support
changes
andexists
for now because we don't have the pipeline object in the include phase. - We only support
project.predefined_variables
,project.ci_instance_variables
,group.ci_variables
andproject.ci_variables
as variables. (https://gitlab.com/gitlab-org/gitlab/-/blob/3477d0fe692b4db08cef4cfd5e19dab63927315c/lib/gitlab/ci/config.rb#L111-133)- more info: #276515 (comment 636250569)
It's behind a feature flag ci_include_rules
(#337507 (closed))
Related to #276515 (closed)
Screenshots or Screencasts (strongly suggested)
Normal run
Adding the variable
Run again
How to setup and validate locally (strongly suggested)
Example below:
- Enable the feature flag
Feature.enable(:ci_include_rules)
- Use
include:rules:if
include: - local: builds.yml rules: - if: '$INCLUDE_BUILDS == "true"' - local: lints.yml test: stage: test script: exit 0
- Run pipelines with and without having
INCLUDE_BUILDS
as a project variable.
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Furkan Ayhan