Skip to content

Replace plain text application secret with a copy button

📖 What does this MR do?

Related to #332844 (closed)

Currently when you create an application (Admin, User, or Group) it displays the secret in plain text on the screen. To improve security this MR replaces the plain text secret with a copy button.

📈 Future iterations

💻 How to setup and validate locally

Admin applications

  1. Navigate to Menu -> Admin -> Applications
  2. Click New application and complete the form

Group applications

  1. Create a group
  2. Navigate to Settings -> Applications and complete the form

User applications

  1. Click your avatar in the upper right corner and select Preferences
  2. Click Applications in the sidebar and complete the form

📷 Screenshots

View Before After
Admin applications Screen_Shot_2021-08-03_at_2.21.25_PM Screen_Shot_2021-08-11_at_9.14.14_AM
Group applications Screen_Shot_2021-08-03_at_2.23.18_PM Screen_Shot_2021-08-11_at_9.12.09_AM
User applications Screen_Shot_2021-08-03_at_2.22.18_PM Screen_Shot_2021-08-11_at_9.14.52_AM

🚦 Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman

Merge request reports

Loading