Update file names and method names after copy change
requested to merge 337545-follow-up-from-update-copy-in-account-recovery-settings-global-alert into master
What does this MR do?
Related to #337545 (closed)
In !66693 (merged) and !68001 (merged) we updated the copy in a global alert to be more specific about checking two-factor authentication recovery settings
vs just recovery settings
. This MR updates file and method names to better match the copy and intent of the alert.
Screenshots or Screencasts (strongly suggested)
No visual changes
Alert for context
How to setup and validate locally (strongly suggested)
- Enable two-factor authentication
- Navigate to
/-/profile/account
- Click "Enable two-factor authentication"
- Open up 1Password
- Click + icon and then "Login"
- Create a new "One-Time Password" section
- Click the QR icon left of the dropdown that was just used
- Drag the QR window over the QR code
- Paste the OTP in the "Pin code" field and click "Register with two-factor app"
- Navigate to
- Download and apply this patch: local-testing.patch
git apply <path to patch>
- Delete the
UserCallout
record for this alertbin/rails console
UserCallout.where({ feature_name: 12 }).destroy_all
- Reload the page
Does this MR meet the acceptance criteria?
Conformity
- [-] I have included changelog trailers, or none are needed. (Does this MR need a changelog?)
- Not needed, developer facing change
- [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
-
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) - [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) - [-] I have tested this MR in all supported browsers, or it's not needed.
- [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Edited by Peter Hegman