Skip to content

Set 36h limit for reviewer to respond when at capacity

Matthias Käppler requested to merge mk-review-response-docs into master

What does this MR do?

I thought we could clarify timing expectations in cases where a reviewer is unlikely to meet the 2 day requirement to first provide a review response to an MR.

By setting a maximum of 36 hours for responding with a non-review response ("Sorry I'm at capacity, I will find someone else instead!"), it gives folks a better target to work with than just "as soon as possible". I first suggest 1 day (24h) but to account for flexible hours, it can be difficult to meet this requirement.

I also clarified the "review response" to actually mean "this MR is reviewed", since I think the language we use here is unnecessarily complicated, and I actually had read this as "some response to the review request, not necessarily the review itself."

Related issues

Author's checklist

To avoid having this MR be added to code verification QA issues, don't add these labels: feature, frontend, backend, ~"bug", or database

Review checklist

Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.

  • If the content requires it, ensure the information is reviewed by a subject matter expert.
  • Technical writer review items:
    • Ensure docs metadata is present and up-to-date.
    • Ensure the appropriate labels are added to this MR.
    • If relevant to this MR, ensure content topic type principles are in use, including:
      • The headings should be something you'd do a Google search for. Instead of Default behavior, say something like Default behavior when you close an issue.
      • The headings (other than the page title) should be active. Instead of Configuring GDK, say something like Configure GDK.
      • Any task steps should be written as a numbered list.
      • If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
  • Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review.
  • Ensure a release milestone is set.
Edited by Matthias Käppler

Merge request reports

Loading