Never fetch more than 101 commits when processing a git push
What does this MR do?
This change limits the number of commits we'll pull from Gitaly when processing hooks for branch/tag push/delete actions to at-most 101.
This limit already exists when creating the initial default branch, but when creating a new non-default branch, or pushing to an existing one, we would read all the commits in the branch from Gitaly before throwing all but the most recent 100 away and processing those for the hooks.
No behaviour changes are implied by this change, we're just skipping unnecessary work by taking advantage of the new limit option to the CommitsBetween RPC.
Since we never want the full list of commits, I change the interface declared in Git::BaseHooksService to make it clearer as well.
Screenshots or Screencasts (strongly suggested)
How to setup and validate locally (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Related to #195667 (closed)
Edited by Nick Thomas