Remove feature flag search_sort_issues_by_popularity

What does this MR do?

Related to #263365

Releasing the feature per the feature flag issue: #334974 (closed)

• Removal of the feature flag file
• Removal of references to the feature flag in the code

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

• If you've tested this before you can disable the Feature flag

  Feature.disable(:search_sort_issues_by_popularity)

• Perform a search for issues using the Search GitLab navbar in the top right
• Select the issues tab
• Verify that the sort by popularity is available
• Select other tabs
• Verify sort by popularity is not available

Does this MR meet the acceptance criteria?

Conformity

• I have included changelog trailers, or none are needed. (Does this MR need a changelog?)
• I have added/updated documentation, or it's not needed. (Is documentation required?)
• I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?)
• I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
• I have self-reviewed this MR per code review guidelines.
• This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines)
• I have followed the style guides.
• This change is backwards compatible across updates, or this does not apply.

Availability and Testing

• I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.)
• I have tested this MR in all supported browsers, or it's not needed.
• I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

• Label as security and @ mention @gitlab-com/gl-security/appsec
• The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• Security reports checked/validated by a reviewer from the AppSec team