Change how we export email for seat usage data
What does this MR do?
Fixes a problem with the new Seat Usage export feature, noticed by @amandarueda while testing - https://gitlab.com/gitlab-org/gitlab/-/issues/337397#note_646853899.
In !67202 (diffs), where we implemented exporting seat usage data as CSV, I've tried the API endpoint behavior to expose only public emails by copy the logic from the UserBasic entity - https://gitlab.com/gitlab-org/gitlab/-/blob/80c745a3aa2c090ab7da666276db481efd4e7ad5/ee/lib/ee/api/entities/user_basic.rb#L11.
What I missed is that for the Seat Usage page we override this in the BillableMember entity - https://gitlab.com/gitlab-org/gitlab/-/blob/80c745a3aa2c090ab7da666276db481efd4e7ad5/ee/lib/ee/api/entities/billable_member.rb#L7, and use User#public_email instead.
This MR updates Groups::SeatUsageExportService to do the same.
Related to #262877 (closed).
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #262877 (closed)