Skip to content

Move validation logic from Vue component to resolvers

Illya Klymov requested to merge xanf-refactor-validation into master

What does this MR do?

In preparation of moving table to GlTable as a part of #267953 (closed) we are removing row related logic and move it in proper place. Previously we were triggering validations on component side, now we mimic typical behavior of store-based applications - trigger validation when we are performing mutation

Basically, no changes visible to end-user are made as a part of this MR

Screenshots or Screencasts (strongly suggested)

GitLab__2_

How to setup and validate locally (strongly suggested)

  • Enable feature bulk_import via Feature.enable(:bulk_import)
  • Open "New group" (/groups/new)
  • Use https://gitlab.com as source instance and GeK1Nis4j-SY1X4sqE5c as personal access token (this token is from separate user on GitLab instance with 0 real data available, so we do not expose any security risks here)
  • Modify any dropdown to target existing project (note: right now this is case sensitive, it is known issue and out of scope of this MR) lete any tasks that are not applicable. -->

Conformity

Availability and Testing

Merge request reports

Loading