Skip to content

Group dashboard reveals number of projects and subgroups

What does this MR do?

This MR ensures that values are not provided from the BE dashboard/groups API for subgroupCount and projectCount on private groups, to guest users.

It also cleans up number_projects_with_delimiter.

Screenshots or Screencasts (strongly suggested)

Before After
Screenshot_2021-08-10_at_16.58.18 Screenshot_2021-08-19_at_15.17.28

How to setup and validate locally (strongly suggested)

  • Create a private group with a private project.
  • Add a non-admin user to the project as a guest.
  • Log in as the user and browse to the groups dashboard.
  • Confirm the changes as per the screenshots above.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #25413 (closed)

Edited by Brandon Labuschagne

Merge request reports

Loading