Skip to content

Use v-safe-html for field help texts in integration form

What does this MR do?

This isn't critical since the help texts are defined in the integration models (in Integration#help and Integration#fields) and can be trusted.

We still want to allow external links using target="blank", so we pass a custom configuration to v-safe-html until this is implemented in gitlab-ui with gitlab-ui#1427 (closed).

We also do the same for the main help texts in integration_form.vue, and add the target and rel attributes where missing.

Thanks to @justin_ho who provided the initial patch for this! 🙇

Issue: #241874 (closed)

Screenshots or Screencasts (strongly suggested)

This change should not have any visible impact. Some examples from integrations with HTML in their help texts:

Campfire:

image

Unify Circuit:

image

How to setup and validate locally (strongly suggested)

  1. Create a project
  2. Navigate to Settings → Integrations
  3. Click one of the integrations
  4. Verify that all HTML renders correctly in the gray box at the top, and in the help labels below each field.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Related to #241874 (closed)

Edited by Markus Koller

Merge request reports

Loading