Skip to content

Moved Source Editor's theming into utilities

Denys Mishunov requested to merge dmishunov/source-editor-utils into master

What does this MR do?

The MR introduces a minor refactoring for Source Editor by moving the theming- and language-related operations which do not depend on Source Editor (but rather on monaco), into the utilities for easier usage for the cases outside of Source Editor (syntax highlighting, etc.).

The MR also significantly improves the tests coverage for ~/editor/utils.js.

Screenshots or Screencasts (strongly suggested)

No visual changes.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Denys Mishunov

Merge request reports

Loading