Use sub-batches in BackfillIntegrationsTypeNew background migration
What does this MR do?
Previously we were ignoring the sub_batch_size argument and using
start_id and stop_id directly, which led to timeouts on staging.
The migration succeeded on production, but this change should help increase the chances for the migration to succeed on self-managed instances as well.
Follow-up to !66928 (merged), in response to !67602 (comment 647562361)
Issue: #333507 (closed), part of the epic &2504 (closed) to rename "services" to "integrations", and specifically the child epic &6177 (closed).
Background Migration Details
See data in previous MR: !66928 (diffs)
The difference is that we're now also sub-dividing each batch into smaller batches, so the queries should be more efficient.
Unfortunately I can't get realistic query plans out of #database-lab because the migration has already succeeded there, i.e. most records now already have type_new set
database reviewers: Let me know if you need more info here.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) - [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
- [-] I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?)
-
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) - [-] I have tested this MR in all supported browsers, or it's not needed.
- [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Related to #333507 (closed)