Retry proxied JiraConnection installation deletion
requested to merge 335014-retry-proxied-jiraconnection-installation-deletion-if-the-remote-server-is-not-reachable into master
What does this MR do?
See: #335014 (closed)
This adds a retry mechanism to the proxied Jira requests to destroy installations.
How to setup and validate locally (strongly suggested)
Set up a webhook that fails (many such services are available for testing).
See the instructions for testing forwarded events (!62144 (merged))
Instead of linking the instance_url
to the working proxied GitLab installation (see https://gitlab.com/-/snippets/2127560), link the failing webhook as instance_url
.
Uninstall the application
See that the webhook receives uninstall hooks, with retries one hour apart.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Related to #335014 (closed)
Edited by Alex Kalderimis