Update copy in recovery settings alert
requested to merge 297366-the-banner-prompting-users-to-check-their-account-recovery-settings-causes-confusion-2 into master
📖 What does this MR do?
Related to #297366 (closed)
In !66693 (merged) we updated the copy in this alert, but we received some feedback that the copy was still confusing. Specifically it was confusing that the alert said We recommend you ensure two-factor authentication is enabled
for users that already had two-factor authentication enabled. The original intent of #297366 (closed) was to remind users to save their recovery codes so we adjusted to the copy to be more explicit about this. We also now only show this alert to users that have two-factor authentication enabled.
💻 How to setup and validate locally
- Enable two-factor authentication
- Navigate to
/-/profile/account
- Click "Enable two-factor authentication"
- Open up 1Password
- Click + icon and then "Login"
- Create a new "One-Time Password" section
- Click the QR icon left of the dropdown that was just used
- Drag the QR window over the QR code
- Paste the OTP in the "Pin code" field and click "Register with two-factor app"
- Navigate to
- Download and apply this patch: local-testing.patch
git apply <path to patch>
- Delete the
UserCallout
record for this alertbin/rails console
UserCallout.where({ feature_name: 12 }).destroy_all
- Reload the page
📷 Screenshots
Before | After |
---|---|
🚦 Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) - [-] I have added/updated documentation, or it's not needed. (Is documentation required?)
-
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) - [-] I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?)
-
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. - [-] I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Edited by Peter Hegman