Refactor unset of User secondary emails on email destroy
What does this MR do?
This is a partial refactoring that contributes to https://gitlab.com/groups/gitlab-org/-/epics/6564
Prior to removing some User methods related to unsetting user input, this removes 3 calls to those methods. This also introduces a list of attributes that we consider "secondary emails", which will be used in follow-up MRs to make "secondary emails" more consistent. The intent of this refactoring is to improve clarity of intent and reduce entanglement between logic that is unrelated.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Contributes to https://gitlab.com/groups/gitlab-org/-/epics/6564