Remove presence validation on User#public_email
What does this MR do?
Since User#public_email was introduced in 2015, the validation rules
have included both allow_blank and presence (which means not-blank).
The allow_blank option takes precedence, so the presence option is
ignored (we know this because the code sets public_email to an empty string that would generally fail the presence validation, and also because we confirmed with manual testing). This removes the presence option so it does not cause
confusion or bugs in the future.
Interestingly, this rule conflict has not been noticed in any past changes to this line:
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Contributes to https://gitlab.com/groups/gitlab-org/-/epics/6564
Edited by Dan Jensen