Skip to content

Fix: packages_and_registries_spec.rb unstable blur trigger issue

What does this MR do?

  • Fix the issue which caused blur event not triggering for JH when content-wrapper has min-height: calc() set which covers the entire body

The original issue can be found JH issues 169

cc @wortschi

Background:

In JH, we introduced customized style rule for content-wrapper with min-height for positioning the global footer (which means the content-wrapper will completely cover body element, in this case the test case used find('body).click to trigger blur event which is blocked by content-wrapper(hypothetically), it was just somehow unable to trigger the event by clicking the body event. So that we use blur event on the input box.

NOTE: The test runs completely ok locally, no idea why inside CI container it just fails.

Screenshots or Screencasts (strongly suggested)

How to setup and validate locally (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Wu Jeremy

Merge request reports

Loading