Extend /help/instance_configuration with size limits
What does this MR do?
On the {base_url}/help/instance_configuration
help page, you can find information about the settings used in your current instance. This MR extends the content of this page with the following size limits:
- Maximum attachment size
- Maximum push size (optional setting, show '-' if not set)
- Maximum import size (show '-' if set to
0
(unlimited)) - Maximum diff patch size
- Maximum job artifact size
- Maximum page size (show '-' if set to
0
(unlimited)) - Maximum snippet size
In addition, the GitLab CI
chapter is removed. That chapter previously contained only the Maximum job artifact size
setting, which is now also listed in the Size Limits
chapter.
/cc @bufferoverflow
Screenshots
before | after |
---|---|
How to setup and validate locally
- Visit
{base_url}/help/instance_configuration
. - Visit
{base_url}/admin/application_settings/general
and set other size limits. - Clear Rails cache
Rails.cache.delete('instance_configuration')
- Visit
{base_url}/help/instance_configuration
.
Does this MR meet the acceptance criteria?
Conformity
-
I have included changelog trailers, or none are needed. (Does this MR need a changelog?) -
I have added/updated documentation, or it's not needed. (Is documentation required?) -
I have properly separated EE content from FOSS, or this MR is FOSS only. (Where should EE code go?) -
I have added information for database reviewers in the MR description, or it's not needed. (Does this MR have database related changes?) -
I have self-reviewed this MR per code review guidelines. -
This MR does not harm performance, or I have asked a reviewer to help assess the performance impact. (Merge request performance guidelines) -
I have followed the style guides. -
This change is backwards compatible across updates, or this does not apply.
Availability and Testing
-
I have added/updated tests following the Testing Guide, or it's not needed. (Consider all test levels. See the Test Planning Process.) -
I have tested this MR in all supported browsers, or it's not needed. -
I have informed the Infrastructure department of a default or new setting change per definition of done, or it's not needed.
Security
Does this MR contain changes to processing or storing of credentials or tokens, authorization and authentication methods or other items described in the security review guidelines? If not, then delete this Security section.
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Jonas Wälter